Skip to content

fix(signal-processing): Apply listener changes #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 16, 2025

Conversation

Techassi
Copy link
Member

This fixes the issues encountered during a fresh install of the nightly demo:

  • The listenerClass field needed to be moved.
  • The endpoint in the ingestion job needed to be adjusted.

See more context in #242 (comment).

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change for correctness

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jul 15, 2025
@Techassi Techassi requested a review from NickLarsenNZ July 15, 2025 14:49
NickLarsenNZ
NickLarsenNZ previously approved these changes Jul 15, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left another suggestion (I think it was missed on the last one).

Feel free to use it or ignore it.

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi merged commit 1eb47dc into main Jul 16, 2025
2 checks passed
@Techassi Techassi deleted the fix/signal-processing-pre-25.7.0 branch July 16, 2025 10:27
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Jul 16, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants